Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust session provider early return logic #164

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

polishq
Copy link
Contributor

@polishq polishq commented Oct 2, 2024

What problem is this solving?

Adjusts the logic of the previous PR so as not to break VTEX "legacy" call center operator impersonation functionality.

In the B2B impersonation scenario, the session provider must validate that the user has a storeUserEmail in their session -- in other words, they must be logged in to the storefront to be able to impersonate another B2B user.

In the legacy impersonation scenario, the user must be accessing account.myvtex.com as an admin user with the call center operator role, but not necessarily logged into the storefront. The storeUserEmail should not be validated in this case.

How should this be manually tested?

New version linked and tested in https://arthur--helmethouseprod.myvtex.com

Copy link

vtex-io-ci-cd bot commented Oct 2, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@polishq polishq requested a review from enzomerca October 2, 2024 20:44
@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 2, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Oct 2, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 13, PR deletions = 2

Generated by 🚫 dangerJS against fae7c48

Copy link

sonarqubecloud bot commented Oct 2, 2024

@enzomerca enzomerca merged commit 07a9434 into master Oct 3, 2024
14 checks passed
@enzomerca enzomerca deleted the fix/impersonation-session branch October 3, 2024 12:26
Copy link

vtex-io-ci-cd bot commented Oct 3, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.8 → 1.44.9

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants